Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug #115

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Minor bug #115

merged 1 commit into from
Dec 21, 2022

Conversation

DrTaDa
Copy link
Contributor

@DrTaDa DrTaDa commented Dec 21, 2022

No description provided.

@DrTaDa DrTaDa marked this pull request as ready for review December 21, 2022 12:29
@DrTaDa DrTaDa requested a review from anilbey December 21, 2022 12:29
Copy link
Contributor

@anilbey anilbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anilbey
Copy link
Contributor

anilbey commented Dec 21, 2022

The tox error is due to numpy 1.24 release but it's coming from the igor dependency
https://numpy.org/doc/stable/release/1.24.0-notes.html#expired-deprecations

@anilbey
Copy link
Contributor

anilbey commented Dec 21, 2022

The repo is here: http://git.tremily.us/?p=igor.git
The last commit was in 2016

Do you know if there's an alternative igor reader?

@DrTaDa
Copy link
Contributor Author

DrTaDa commented Dec 21, 2022

yeah Aurélien already opened a PR yesterday, we are waiting to hear from the dev

@DrTaDa DrTaDa merged commit b201147 into master Dec 21, 2022
@DrTaDa DrTaDa deleted the Fix branch December 21, 2022 14:11
DrTaDa added a commit that referenced this pull request Jan 5, 2023
DrTaDa added a commit that referenced this pull request Jan 5, 2023
DrTaDa added a commit that referenced this pull request Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants