Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize python connect #502

Closed
tribal-tec opened this issue Aug 9, 2018 · 0 comments · Fixed by #531
Closed

Optimize python connect #502

tribal-tec opened this issue Aug 9, 2018 · 0 comments · Fixed by #531
Labels
enhancement
Milestone
Brayns 0.7

Comments

@tribal-tec
Copy link
Contributor

For braynsViewer, the initial connect from python (more precisely the notebook) is slow because it handles only one message per frame, meaning for slow renderings, the connect takes 140 * render-time.

Solution is to reduce the number of messages sent by python by using RPC batch requests for the schemas of all objects and methods. The number of messages for the connect should be 3 (version, registry, schemas).
@tribal-tec tribal-tec added this to the Brayns 0.7 milestone Aug 9, 2018
tribal-tec added a commit to tribal-tec/Brayns that referenced this issue Aug 22, 2018
@tribal-tec
Support batch JSON-RPC in python client
7201267 
This is used to batch request all schemas to reduce the number of roundtrips
which boosts the performance of the initial connect (closes BlueBrain#502).
@tribal-tec tribal-tec mentioned this issue Aug 22, 2018
Merged
tribal-tec added a commit to tribal-tec/Brayns that referenced this issue Aug 23, 2018
@tribal-tec
Support batch JSON-RPC in python client
78cfa1e 
This is used to batch request all schemas to reduce the number of roundtrips
which boosts the performance of the initial connect (closes BlueBrain#502).
tribal-tec added a commit that referenced this issue Aug 23, 2018
@tribal-tec
Support batch JSON-RPC in python client
690edc8 
This is used to batch request all schemas to reduce the number of roundtrips
which boosts the performance of the initial connect (closes #502).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Brayns 0.7
Development

Successfully merging a pull request may close this issue.

Support batch JSON-RPC in python client tribal-tec/Brayns
1 participant
@tribal-tec