Support batch JSON-RPC in python client #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandjitsu
reviewed
Aug 23, 2018
python/brayns/api_generator.py
Outdated
| if _try_add_method(target_object, url, registry_entry): | ||
| if registry_entry in schemas: | ||
| schema = schemas[registry_entry] | ||
| elif registry_entry.endswith('/schema'): |
There was a problem hiding this comment.
You could make a const for /schema, it seems to be used in other files.
| def callback(payload): | ||
| """ | ||
| The callback for the response. | ||
| if response_timeout: |
There was a problem hiding this comment.
Is the timeout applied for snapshot requests as well? Because snapshot requests could take a long time.
There was a problem hiding this comment.
The image() function does not use a timeout. snapshot() as a generated function has one, but the user can always set a different/none timeout.
rolandjitsu
approved these changes
Aug 23, 2018
This is used to batch request all schemas to reduce the number of roundtrips which boosts the performance of the initial connect (closes BlueBrain#502).
tribal-tec
force-pushed
the
python_connect
branch
from
7201267
to
78cfa1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used to batch request all schemas to reduce the number of roundtrips
which boosts the performance of the initial connect (closes #502).