Use lexis/render/Stream event to Deflect stream available via HTTP #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
favreau
reviewed
Nov 1, 2016
| deflectImage.compressionPolicy = | ||
| ( deflectImage.compressionQuality != 100 ) ? | ||
| _params.getCompression() ? |
There was a problem hiding this comment.
Following our discussion, it's probably better to have 2 different parameters for the quality and the activation of the compression. For the records, compressing to 100% gives the same quality as compression disabled, but removes the Alpha information.
There was a problem hiding this comment.
That's what I have now?! getCompression() is ON/OFF and there is getQuality().
|
Nice functionality! Fix the GitExternal.cmake SHA1 (51a2753 -> a853636 ?) and it should be all good. |
|
retest this please |
|
Needs approval for merge |
favreau
approved these changes
Nov 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.