Fixed shadows on simulation data #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribal-tec
reviewed
Aug 10, 2018
| { | ||
| const uniform Light* uniform light = | ||
| attributes.self->abstract.lights[i]; | ||
| const vec2f s = make_vec2f(0.5f); |
There was a problem hiding this comment.
what's the purpose of this value? comment or better name.
There was a problem hiding this comment.
replaced by samplingLocation
| } | ||
|
|
||
| if (attributes.shadowIntensity > 0.f) | ||
| // Remove specular color is surface is in the shades |
There was a problem hiding this comment.
'is surface' -> 'if surface'
|
Retest this please |
favreau
changed the title
|
Ping |
karjonas
approved these changes
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.