-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed shadows on simulation data #508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message 'managememt' typo. Maybe just say 'Fixed shadows on simulation data'? Not much management here :p
{ | ||
const uniform Light* uniform light = | ||
attributes.self->abstract.lights[i]; | ||
const vec2f s = make_vec2f(0.5f); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the purpose of this value? comment or better name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replaced by samplingLocation
} | ||
|
||
if (attributes.shadowIntensity > 0.f) | ||
// Remove specular color is surface is in the shades |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'is surface' -> 'if surface'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Retest this please |
Ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to trust that this works but I would appreciate a unit test with voxels so we can actually see the change graphically :)
No description provided.