Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make selection lifetime independant of their parent dataset #1

Closed
adevress opened this issue Dec 11, 2015 · 1 comment
Closed

Make selection lifetime independant of their parent dataset #1

adevress opened this issue Dec 11, 2015 · 1 comment

Comments

@adevress
Copy link
Collaborator

For now, HDF5 hyperslap are valid only for the time life of their parent dataset object.

Currently, HighFive selection do not increase the reference counter of their parent DataSet.

This can lead to confusing situation like

_hdf5_file.getDataSet("fdfdfd").select(...)

Where parent dataset lifetime is inferior to selection lifetime, creating invalid selection object.

The solution to this is to make "Selection" object to own a dataset reference ( increase reference counter ) instead of just using a weak reference.
adevress added a commit that referenced this issue Dec 16, 2015
@adevress
Solve Selection/Dataset reference github issue #1
21e104a 
- Convert reference to Dataset from simple C++ reference to full object with COW patter
@adevress
Copy link
Collaborator Author

Solved and tested

@basegpu basegpu mentioned this issue Jan 5, 2018
Closed
@alamj alamj mentioned this issue Apr 7, 2022
Closed
@YoniSp YoniSp mentioned this issue Sep 19, 2022
Closed
@ccorti87 ccorti87 mentioned this issue Jun 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adevress