Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid name collision with macros TRUE and FALSE. #722

Merged
merged 1 commit into from Apr 4, 2023

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Apr 3, 2023

See #721.

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@2759770). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #722   +/-   ##
=========================================
  Coverage          ?   82.42%           
=========================================
  Files             ?       67           
  Lines             ?     4513           
  Branches          ?        0           
=========================================
  Hits              ?     3720           
  Misses            ?      793           
  Partials          ?        0           
Impacted Files Coverage Δ
include/highfive/bits/H5Converter_misc.hpp 85.84% <ø> (ø)
include/highfive/bits/H5DataType_misc.hpp 78.64% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@1uc
Copy link
Collaborator Author

1uc commented Apr 3, 2023

While details::Boolean::HighFiveFalse seems excessive, False looks to much like the Python name for true. We're free to rename it as it's not part of the API, so the only concern is to avoid macros interfering.

@1uc 1uc force-pushed the 1uc/fix-boolean-namecollision branch from 727f637 to a744dd4 Compare April 4, 2023 05:39
@1uc 1uc marked this pull request as ready for review April 4, 2023 05:55
@1uc 1uc merged commit add5c49 into master Apr 4, 2023
24 checks passed
@1uc 1uc deleted the 1uc/fix-boolean-namecollision branch April 4, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants