Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Windows.h to uncover more defects on Windows. #723

Merged
merged 1 commit into from Apr 4, 2023

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Apr 3, 2023

The purpose is to make our CI more sensitive to name clashes of macros with tokens we've used in HighFive. The idea is that by including Windows.h we should be pulling in many standard macros. Hence we should be able to detect the defect.

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #723 (aca7479) into master (add5c49) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head aca7479 differs from pull request most recent head bd4a057. Consider uploading reports for the commit bd4a057 to get more accurate results

@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
- Coverage   82.42%   82.39%   -0.04%     
==========================================
  Files          67       67              
  Lines        4513     4504       -9     
==========================================
- Hits         3720     3711       -9     
  Misses        793      793              
Impacted Files Coverage Δ
include/highfive/bits/H5Converter_misc.hpp 85.84% <ø> (ø)
tests/unit/tests_high_five.hpp 100.00% <ø> (ø)
include/highfive/bits/H5DataType_misc.hpp 78.64% <100.00%> (ø)
tests/unit/tests_high_five_base.cpp 99.65% <100.00%> (-0.01%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@1uc 1uc force-pushed the 1uc/more-sensitive-unit-tests branch 2 times, most recently from aca7479 to d01b019 Compare April 3, 2023 15:58
@1uc
Copy link
Collaborator Author

1uc commented Apr 3, 2023

This requires #725 and #722 to pass.

@1uc 1uc force-pushed the 1uc/more-sensitive-unit-tests branch from d01b019 to bd4a057 Compare April 4, 2023 08:51
@1uc 1uc marked this pull request as ready for review April 4, 2023 09:06
@1uc 1uc merged commit 2ffb943 into master Apr 4, 2023
24 checks passed
@1uc 1uc deleted the 1uc/more-sensitive-unit-tests branch April 4, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants