Select product of slices. #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #842 +/- ##
==========================================
+ Coverage 86.81% 87.11% +0.30%
==========================================
Files 100 100
Lines 6081 6223 +142
==========================================
+ Hits 5279 5421 +142
Misses 802 802 ☔ View full report in Codecov by Sentry. |
1uc
force-pushed
the
1uc/product-slices
branch
3 times, most recently
from
fb5a1a2
to
07c1706
Compare
|
Related to: #852 |
1uc
force-pushed
the
1uc/product-slices
branch
3 times, most recently
from
1ec3008
to
4f4e380
Compare
1uc
force-pushed
the
1uc/product-slices
branch
from
4f4e380
to
25d94de
Compare
matz-e
reviewed
Jun 11, 2024
| check(array, subarray, yslices, xslices); | ||
| } | ||
|
|
||
| SECTION("pR") { |
There was a problem hiding this comment.
I wasn't scared that I'd be missing anything by skipping those, I'll add them.
matz-e
approved these changes
Jun 12, 2024
matz-e
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.