Fixed resolution print. Replaced volume bounding box by dataToLivreTr… #313
Conversation
| Replaced the data bounding box by the data to Livre spaces | ||
| transform matrix computed by the datasource for camera | ||
| synchronization. Added meterToDataUnitRatio parameter | ||
| computed by the datasource. Fixed resolution printing. |
There was a problem hiding this comment.
Add a bullet list for better reading?
|
Is this commit really standalone? |
|
It can be. There is no camera synch yet, but it will compile and work. It is also needed for Fivox to compile. This commit is fixing the resolution print and adding some fields in the volumeinformation class. |
|
Updated |
| #ifdef LIVRE_USE_ZEROEQ | ||
| _impl->communicator->publishCamera(); | ||
| #endif | ||
| //#ifdef LIVRE_USE_ZEROEQ |
| @@ -4,6 +4,7 @@ Changelog {#Changelog} | |||
| # master {#master} | |||
|
|
|||
| * [#313](https://github.com/BlueBrain/Livre/pull/313): | |||
| Camera synchronization is working. | |||
There was a problem hiding this comment.
Fixed the camera synchronization between applications.
…ansform and added meterToDataUnitRatio in VolumeInformation class.
| Matrix4f networkModelView( &matrixValues[0], &matrixValues[0] + 16 ); | ||
|
|
||
| Vector4f translation = networkModelView.getColumn( 3 ); | ||
| Matrix4f rotation; |
There was a problem hiding this comment.
You can simply inverse the received matrix, get the last column for translate.
chevtche
force-pushed
the
master
branch
3 times, most recently
from
8086a1b
to
e23af8e
Compare
|
Updated |
| @@ -4,6 +4,7 @@ Changelog {#Changelog} | |||
| # master {#master} | |||
|
|
|||
| * [#313](https://github.com/BlueBrain/Livre/pull/313): | |||
| Camera synchronization is working. | |||
| Replaced the data bounding box by the data to Livre spaces | |||
There was a problem hiding this comment.
What do you mean by Livre space ? It's not only livre space, RTNeuron camera is also synchronized.
| @@ -63,13 +62,33 @@ class CameraSettings : public co::Distributable< ::lexis::render::LookOut > | |||
| void setCameraPosition( const Vector3f& position ); | |||
|
|
|||
| /** | |||
| * Register a callback for camera changes. | |||
| * @param position | |||
|
Mergeable or not mergeable... this is the question! |
|
+1 after changelog |
| { | ||
| const Vector3f resolution = info.resolution; | ||
|
|
||
| const float ratio = 1.0f / dataSource.getVolumeInfo().meterToDataUnitRatio; |
There was a problem hiding this comment.
Don't call getVolumeInfo again, use the local variable info.
chevtche
force-pushed
the
master
branch
2 times, most recently
from
4682b08
to
e445c98
Compare
…ansform and added meterToDataUnitRatio in VolumeInformation class.