Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Relax numpy max version #72

Merged
merged 1 commit into from Jun 22, 2023
Merged

Build: Relax numpy max version #72

merged 1 commit into from Jun 22, 2023

Conversation

adrien-berchet
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #72 (9c4afa1) into main (411203c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   97.57%   97.59%   +0.01%     
==========================================
  Files          39       39              
  Lines        2148     2159      +11     
  Branches      330      332       +2     
==========================================
+ Hits         2096     2107      +11     
  Misses         35       35              
  Partials       17       17              
Flag Coverage Δ
pytest 97.59% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neurots/generate/orientations.py 100.00% <100.00%> (ø)
neurots/generate/tree.py 98.90% <100.00%> (ø)
neurots/morphmath/rotation.py 100.00% <100.00%> (ø)

@adrien-berchet adrien-berchet linked an issue Jun 22, 2023 that may be closed by this pull request
Copy link
Contributor

@arnaudon arnaudon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good, it works on bb5 as well, thank you!

@adrien-berchet adrien-berchet merged commit 604c029 into main Jun 22, 2023
9 checks passed
@adrien-berchet adrien-berchet deleted the relax_numpy branch June 22, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numpy 1.25 breaks many tests...
2 participants