Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if .asc files as input #24

Merged
merged 9 commits into from
Jan 23, 2020
Merged

check if .asc files as input #24

merged 9 commits into from
Jan 23, 2020

Conversation

arnaudon
Copy link
Collaborator

Had the classic issue of inputing .asc files instead of .h5 or .swc, so added a line to raise an exception if some .asc files are givenb to TMD to generate distribution and parameters.

Copy link
Collaborator

@lidakanari lidakanari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add back the "tree_type_finals"

@arnaudon
Copy link
Collaborator Author

sorry about the conflict versions, it should be back now

tmd/io/io.py Outdated Show resolved Hide resolved
tmd/io/io.py Outdated Show resolved Hide resolved
@lidakanari
Copy link
Collaborator

It looks like something is wrong with Travis and the checks don't run. @wizmer could you help fix this?

@wizmer
Copy link
Contributor

wizmer commented Jan 22, 2020

I have no idea. @arnaudon Could you try adding a commit to see if this was a fluke ?

@lidakanari
Copy link
Collaborator

It is the same for other PR (#25) so I assume this is a more general issue.

@arnaudon
Copy link
Collaborator Author

Just got my account to be part of BlueBrain, and did a new push on my fork. It seems that it still does not work...

@mgeplf
Copy link
Collaborator

mgeplf commented Jan 23, 2020

@arnaudon Have you ever logged into https://travis-ci.org?

@arnaudon
Copy link
Collaborator Author

So my travis account was flagged for potential abuse, and after being unflagged, the build could be run, so feel free to merge!

@lidakanari lidakanari merged commit d0b80d6 into BlueBrain:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants