Ignore secondary annotations (undefined annotations in TYPE_DCT) #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annotations that are not declared in TYPE_DCT. This prevents breakage of load_neuron when data contains undeclared structural annotations (eg. contours, spines). These undeclared structural annotations have not the same origin points as the soma, basal, apical, or axon (TYPE_DCT). During csr_matrix generation the annotations require to be connected with soma, therefore those undeclared annotations often break the loading of data. To block annoying error messages an verbose argument is added to suppress printing of the messages.
to be processed. Otherwise in case of LoadNeuronError the loading is stopped.
|
Hi @BCJongbloets I think Travis is not running your build because of a flagged account. Could you loggin to https://travis-ci.org/ and see if you have a notification about it ? |
|
Hi Benoit,
I did not have Travis enabled on this project. I now made an account with Travis and have enabled it for my forked repro. However I have no clue what pipeline to run using Travis.
Do you have a predefined .travis.yml for this project?
Bart
… On Jan 23, 2020, at 01:30, Benoit Coste ***@***.***> wrote:
Hi @BCJongbloets <https://github.com/BCJongbloets> I think Travis is not running your build because of a flagged account. Could you loggin to https://travis-ci.org/ <https://travis-ci.org/> and see if you have a notification about it ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#25?email_source=notifications&email_token=ADUEYBXENRKZPWW2BANN5RLQ7FPTNA5CNFSM4KJMMHRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJWXM6A#issuecomment-577599096>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUEYBQA65BMBRVVZXNREJTQ7FPTNANCNFSM4KJMMHRA>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of reconstruction data files with structural annotations for anatomical contours fail to load
in the current TMD package. This is because those annotations usually are not connected with the
soma or any of the processes (basal, apical, axon) as defined in TYPE_DCT. To allow for loading of
the data we can remove all data that is not defined in TYPE_DCT. A 'verbose' argument is added
to allow the user to avoid superfluous printing of the warning that data was removed.
I hope you find this edit useful, also included a test file that would in the current version of TMD
cannot be read, but with the edit will be read. This file was converted from a neurolucida .DAT file to
SWCplus file with (https://neuroinformatics.nl/HBP/morphology-viewer/).
BJ2510_a1_MSaa00455_PVAi9-4473_B2_traced_BCJ.swc.txt
*had to add .txt to allow for import