Tweak UI design, refactor UI control logic, cleanup and reorganize code #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 18, 2018 11:34
tribal-tec
approved these changes
Jul 20, 2018
tide/core/resources/SideControl.qml
Outdated
| sourceComponent: buttonDelegate | ||
| } | ||
| // Can't be made a top-level item; this results in unexplained incorrect | ||
| // centering of buttons inside the Canevas. |
tide/core/scene/Content.h
Outdated
| /** The different types of interaction. */ | ||
| enum class Interaction | ||
| { | ||
| AUTO, // interaction is enabled automatically (default) |
There was a problem hiding this comment.
lower-case values? auto does not work then probably. what does auto interaction mean? depending on content type?
There was a problem hiding this comment.
will do, yes that's another thing which could be improved, AUTO is not clear. It serves only for zoomable contents where interaction mode can be changed by tap-and-hold to modify zoom.
tide/core/scene/PixelStreamContent.h
Outdated
| @@ -120,7 +124,7 @@ class PixelStreamContent : public MultiChannelContent | |||
| const unsigned int version) | |||
| { | |||
| serialize_members_xml(ar, version); | |||
| _createActions(); // actions are not saved to xml file | |||
| _createKeyboard(); // actions are not saved to xml file | |||
There was a problem hiding this comment.
in fact this had to be removed, thanks!
| @@ -39,6 +39,11 @@ | |||
|
|
|||
| #include "ScreenLock.h" | |||
|
|
|||
| ScreenLockPtr ScreenLock::create() | |||
| { | |||
| return ScreenLockPtr(new ScreenLock); | |||
There was a problem hiding this comment.
doesn't work in this case because the constructor is private and make_unique/shared complains about that
tide/wall/WallApplication.cpp
Outdated
| _initMPIConnection(); | ||
|
|
||
| _renderController->updateScene(Scene::create(config.surfaces)); | ||
| _renderController.reset(new RenderController(*_config, *_provider, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.