Added customisable percentages to AP_rise_time. #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AurelienJaquier
force-pushed
the
master
branch
from
59b21dd
to
fc3cfe1
Compare
|
Could you just add a test for this extra setting? Thx. |
AurelienJaquier
force-pushed
the
master
branch
from
fc3cfe1
to
158781a
Compare
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
- Coverage 67.23% 67.17% -0.07%
==========================================
Files 12 12
Lines 2045 2047 +2
==========================================
Hits 1375 1375
- Misses 670 672 +2
Continue to review full report at Codecov.
|
anilbey
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #194
Rise time window can now be changed by setting "rise_start_perc" and "rise_end_perc". Both values should be between 0.0 and 1.0. They are 0.0 and 1.0 by default.
E.g. if rise_start_perc is 0.1, and rise_end_perc is 0.9, it means that the rise time will be computed between the first time the voltage gets above (or equal) 10% of the AP amplitude, and the last time the voltage is below 90% of the AP amplitude.