Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3012 paging not working for es #373

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Conversation

nicwells
Copy link
Contributor

Fixes BlueBrain/nexus#3012

Put paging options (size and from) into body of request rather than as query params which seem to get ignored.

Paging options, size and from, do not work when submitting POST to Elasticsearch with these params in the query string
@codecov-commenter
Copy link

Codecov Report

Merging #373 (cd70c6d) into main (82e0d2b) will increase coverage by 0.12%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
+ Coverage   88.66%   88.79%   +0.12%     
==========================================
  Files          23       24       +1     
  Lines         547      571      +24     
  Branches      130      140      +10     
==========================================
+ Hits          485      507      +22     
- Misses         60       62       +2     
  Partials        2        2              
Impacted Files Coverage Δ
packages/nexus-sdk/src/Resource/index.ts 93.75% <80.00%> (-3.62%) ⬇️
packages/nexus-sdk/src/GraphAnalytics/index.ts 100.00% <100.00%> (ø)
packages/nexus-sdk/src/Project/index.ts 80.00% <100.00%> (+1.05%) ⬆️
packages/nexus-sdk/src/View/index.ts 87.23% <100.00%> (ø)
packages/nexus-sdk/src/nexusSdk.ts 83.72% <100.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f97f002...cd70c6d. Read the comment docs.

@dhaneshnm dhaneshnm merged commit c3c28fa into main Jan 17, 2022
@dhaneshnm dhaneshnm deleted the 3012-paging-not-working-for-es branch January 17, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paging not working correctly when querying Elasticsearch in Project Query
3 participants