References for 'https://github.com/BlueBrain/nmodl/pull/1260'. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1uc
commented
May 14, 2024
| @@ -190,8 +324,15 @@ namespace neuron { | |||
| } | |||
|
|
|||
|
|
|||
| inline double nrn_current_leonhard(size_t id, leonhard_Instance& inst, leonhard_NodeData& node_data, double v) { | |||
| inline double nrn_current_leonhard(_nrn_model_sorted_token const& _sorted_token, NrnThread* _nt, Memb_list* _ml_arg, int _type, size_t id, leonhard_Instance& inst, leonhard_NodeData& node_data, double v) { | |||
There was a problem hiding this comment.
Setting up _lmr should happen outside the loop. nrn_current_* is a function that's only called in the loop body of nrn_cur_*.
It might be better to pass it in.
| double current = 0.0; | ||
| func_leonhard(_ml, inst, id, _ppvar, _thread, _nt); |
There was a problem hiding this comment.
This seems to be a sensible set of stuff to also pass into nrn_current_leonhard:
_ml, inst, id, _ppvar, _thread, _nt
(plus specific things).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.