Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing variables when calling a FUNCTION or PROCEDURE in BREAKPOINT block #1260

Merged
merged 10 commits into from
May 16, 2024

Conversation

JCGoran
Copy link
Contributor

@JCGoran JCGoran commented May 14, 2024

No description provided.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request May 14, 2024
@JCGoran JCGoran marked this pull request as ready for review May 14, 2024 11:22
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 86.32%. Comparing base (49da686) to head (42e4bd8).

Files Patch % Lines
src/codegen/codegen_neuron_cpp_visitor.cpp 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1260      +/-   ##
==========================================
- Coverage   86.35%   86.32%   -0.04%     
==========================================
  Files         175      175              
  Lines       13214    13219       +5     
==========================================
  Hits        11411    11411              
- Misses       1803     1808       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also consider comments made here:
BlueBrain/nmodl-references#18

test/usecases/nonspecific_current/leonhard.mod Outdated Show resolved Hide resolved
@JCGoran JCGoran mentioned this pull request May 15, 2024
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request May 15, 2024
@bbpbuildbot

This comment has been minimized.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request May 15, 2024
@bbpbuildbot

This comment has been minimized.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request May 15, 2024
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #211280 (:white_check_mark:) have been uploaded here!

Status and direct links:

@1uc 1uc merged commit a8f1829 into master May 16, 2024
21 checks passed
@1uc 1uc deleted the jelic/fix_missing_vars_again branch May 16, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants