-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move nmodl python files into subdirectory #462
Comments
@alkino : this is for the master branch. |
this is difficult to do in python since the name of the module IS the name of the top level folder (there there is __init __.py, the one that you want to rename). You could stuff the folder in another folder (i.e. |
anyway, if you really want to put it into something like: https://stackoverflow.com/questions/14417236/setup-py-renaming-src-package-to-project-name |
* replace `setup.py` with `pyproject.toml` * move all Python package requirements to single `requirements.txt` * remove checking Python package requirements in `CMakeLists.txt` * move Python bindings to own dir (python/nmodl), fixes #462 * add separate script for generating docs * add `packaging/change_name.py` script to as workaround to enable both NMODL and NMODL-nightly wheels in CI * update documentation and CI to reflect above changes --------- Co-authored-by: Luc Grosheintz <luc.grosheintz@gmail.com>
* replace `setup.py` with `pyproject.toml` * move all Python package requirements to single `requirements.txt` * remove checking Python package requirements in `CMakeLists.txt` * move Python bindings to own dir (python/nmodl), fixes #462 * add separate script for generating docs * add `packaging/change_name.py` script to as workaround to enable both NMODL and NMODL-nightly wheels in CI * update documentation and CI to reflect above changes --------- Co-authored-by: Luc Grosheintz <luc.grosheintz@gmail.com>
Currently the nmodl python module files are in a top level directory called
nmodl
. Having the same name as the package itself it often leads to confusion especially when testing the python package. Various scenarios fail because python uses the current working dir as a search dir for modules. This way the localnmodl
directory will take precedence over an installednmodl
python module (eg. insite-packages
). We have several workarounds to address this, but we keep finding scenarios, where confusing errors show up.A proper fix is needed. For example the
nmodl
directory should be moved into another dir, maybe namedpkg
. It is not sufficient to move the directory as this will entail a number of changes in the build system and CI:This list is non-exhaustive but should cover most of what is needed.
The text was updated successfully, but these errors were encountered: