Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KINETIC block visitor in case there is an empty statement #1009

Merged
merged 8 commits into from
Aug 30, 2023

Conversation

iomaganaris
Copy link
Contributor

Fixes compilation of mod files of dbbs-mod-collection (after small changes in mod files in https://github.com/iomaganaris/dbbs-mod-collection/tree/magkanar/nmodl)

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #1009 (e4a7cf6) into master (a1a035c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1009   +/-   ##
=======================================
  Coverage   69.98%   69.98%           
=======================================
  Files         188      188           
  Lines       25659    25659           
=======================================
  Hits        17957    17957           
  Misses       7702     7702           
Files Changed Coverage Δ
src/visitors/kinetic_block_visitor.cpp 96.13% <100.00%> (ø)

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #147025 (:white_check_mark:) have been uploaded here!

Status and direct links:

@iomaganaris iomaganaris changed the title Various codegen fixes Fix KINETIC block visitor in case there is an empty statement Aug 28, 2023
@iomaganaris
Copy link
Contributor Author

Should we merge this now @pramodk @cattabiani ?

@cattabiani
Copy link
Contributor

Sorry, I missed the mail. LGTM!

@pramodk pramodk merged commit a662a45 into master Aug 30, 2023
17 checks passed
@pramodk pramodk deleted the magkanar/dbbs_fixes branch August 30, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dbbs-mod-collection] Issues with KINETIC block
5 participants