Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KINETIC block visitor in case there is an empty statement #1009

Merged
merged 8 commits into from
Aug 30, 2023
Merged

Fix KINETIC block visitor in case there is an empty statement #1009

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d16bba4
Define functor after function declaration
iomaganaris Mar 2, 2023
5b9bbbd
Fix issue with empty ode_rhs
iomaganaris Mar 3, 2023
fbc66a7
Make format happy
iomaganaris Mar 6, 2023
6636484
Avoid printing ode_rhs related code when ode_rhs is empty
iomaganaris Mar 24, 2023
33901b7
Merge branch 'master' into magkanar/dbbs_fixes
iomaganaris Mar 24, 2023
5e49786
Merge branch 'master' into magkanar/dbbs_fixes
iomaganaris Apr 10, 2023
aa7346d
Fix format
iomaganaris Apr 20, 2023
e4a7cf6
Merge branch 'master' into magkanar/dbbs_fixes
1uc Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/visitors/kinetic_block_visitor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ void KineticBlockVisitor::visit_kinetic_block(ast::KineticBlock& node) {
}
}
// divide by COMPARTMENT factor if present
if (!compartment_factors[j].empty()) {
if (!compartment_factors[j].empty() && !ode_rhs.empty()) {
ode_rhs = fmt::format("({})/({})", ode_rhs, compartment_factors[j]);
}
// if rhs of ODE is not empty, add to list of ODEs
Expand Down
Loading