Use NMODLHOME for NMODL_WRAPLIB #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1041 +/- ##
==========================================
- Coverage 70.07% 70.07% -0.01%
==========================================
Files 190 190
Lines 25803 25804 +1
==========================================
Hits 18081 18081
- Misses 7722 7723 +1
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Logfiles from GitLab pipeline #120612 (:white_check_mark:) have been uploaded here! Status and direct links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use NMODLHOME for wraplib and modlunit
Also fix that
libpywrapperis written inCMAKE_BINARY_PREFIXbut read by tests inNMODL_PROJECT_BINARY_PREFIX.That is not the case for
nrnunits.libthat is written inNMODL_PROJECT_BINARY_PREFIX.The problem was that when installed through nrn cmake, both files appears in different path.