Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify CodegenCppVisitor #1076

Merged
merged 5 commits into from
Sep 21, 2023
Merged

Simplify CodegenCppVisitor #1076

merged 5 commits into from
Sep 21, 2023

Conversation

iomaganaris
Copy link
Contributor

  • Rename C to C++ in multiple places
  • Remove wrapper_printer and target_printer since we only print a single C++ file now for all the backends (C++, OpenACC/OpenMP). There is no more ISPC which needed the wrapper.

pramodk
pramodk approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/codegen/codegen_cpp_visitor.hpp Show resolved Hide resolved
tristan0x
tristan0x approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@tristan0x tristan0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Sorry for the conflict @iomaganaris ¯_(ツ)_/¯

@iomaganaris
Copy link
Contributor Author

LGTM! Sorry for the conflict @iomaganaris ¯_(ツ)_/¯

Haha no worries, it was nothing serious 😇

@codecov
Copy link

codecov bot commented Sep 21, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (4a6d511) 70.19% compared to head (ab9a6b2) 70.19%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1076      +/-   ##
==========================================
- Coverage   70.19%   70.19%   -0.01%     
==========================================
  Files         188      188              
  Lines       25632    25630       -2     
==========================================
- Hits        17992    17990       -2     
  Misses       7640     7640
Files Changed Coverage Δ
src/codegen/codegen_acc_visitor.hpp 50.00% <ø> (ø)
src/codegen/codegen_acc_visitor.cpp 64.10% <100.00%> (ø)
src/codegen/codegen_cpp_visitor.cpp 85.56% <100.00%> (ø)
src/codegen/codegen_cpp_visitor.hpp 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #154703 (:white_check_mark:) have been uploaded here!

Status and direct links:

@iomaganaris iomaganaris merged commit f180a2d into master Sep 21, 2023
17 checks passed
@iomaganaris iomaganaris deleted the magkanar/codegen_improvements branch September 21, 2023 15:15
ohm314 pushed a commit that referenced this pull request Oct 5, 2023
@iomaganaris
Simplify CodegenCppVisitor (#1076)
59c94b8 
* Remove wrapper_printer and target_printer since we only print a single C++ file now for all the backends
* Rename C to C++ in multiple places
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alkino alkino alkino approved these changes

@tristan0x tristan0x tristan0x approved these changes

@pramodk pramodk pramodk approved these changes

@ohm314 ohm314 Awaiting requested review from ohm314

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iomaganaris @bbpbuildbot @alkino @tristan0x @pramodk