Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate Gitlab CI. #1177

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Deactivate Gitlab CI. #1177

merged 2 commits into from
Feb 27, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Feb 27, 2024

Gitlab is currently completely broken and unusable. Hence we deactivate it until it can be used.

Gitlab is currently completely broken and unusable. Hence we deactivate
it until it can be used.
@pramodk
Copy link
Contributor

pramodk commented Feb 27, 2024

@1uc: if it's matter of days (assuming its temporary gitlab glitch), is making it an optional from GitHub settings is an option as well?

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.17%. Comparing base (39922a3) to head (1fbade8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1177   +/-   ##
=======================================
  Coverage   87.17%   87.17%           
=======================================
  Files         175      175           
  Lines       12878    12878           
=======================================
  Hits        11227    11227           
  Misses       1651     1651           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1uc 1uc closed this Feb 27, 2024
@1uc 1uc reopened this Feb 27, 2024
@1uc
Copy link
Collaborator Author

1uc commented Feb 27, 2024

@pramodk it would still generate jobs on Gitlab. We don't know how they're gonna fix it. The "fix" might require us to cancel everything that didn't start. We can get it back with a simple git revert.

@1uc 1uc marked this pull request as ready for review February 27, 2024 08:56
@1uc
Copy link
Collaborator Author

1uc commented Feb 27, 2024

We had to disable the "Required" check, because not running is the same as not passing. We ended up disabling all "Required" checks, because we should merge when CI is green and not merge when it's red.

If CI is spuriously red, it needs to be fixed and if that's absolutely impossible disabled or removed.

Copy link
Contributor

@JCGoran JCGoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should just remember to re-enable it when the cluster is fixed.

@1uc 1uc merged commit a44fe78 into master Feb 27, 2024
18 checks passed
@1uc 1uc deleted the 1uc/kill-gitlab-ci branch February 27, 2024 09:35
JCGoran added a commit that referenced this pull request Feb 27, 2024
pramodk pushed a commit that referenced this pull request Feb 27, 2024
Revert "Deactivate Gitlab CI (#1177)" - commit a44fe78.
ohm314 pushed a commit that referenced this pull request May 21, 2024
Gitlab is currently completely broken and unusable. Hence we deactivate
it until it can be used.
ohm314 pushed a commit that referenced this pull request May 21, 2024
Revert "Deactivate Gitlab CI (#1177)" - commit a44fe78.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants