-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deactivate Gitlab CI. #1177
Deactivate Gitlab CI. #1177
Conversation
Gitlab is currently completely broken and unusable. Hence we deactivate it until it can be used.
@1uc: if it's matter of days (assuming its temporary gitlab glitch), is making it an optional from GitHub settings is an option as well? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1177 +/- ##
=======================================
Coverage 87.17% 87.17%
=======================================
Files 175 175
Lines 12878 12878
=======================================
Hits 11227 11227
Misses 1651 1651 ☔ View full report in Codecov by Sentry. |
@pramodk it would still generate jobs on Gitlab. We don't know how they're gonna fix it. The "fix" might require us to cancel everything that didn't start. We can get it back with a simple |
We had to disable the "Required" check, because not running is the same as not passing. We ended up disabling all "Required" checks, because we should merge when CI is green and not merge when it's red. If CI is spuriously red, it needs to be fixed and if that's absolutely impossible disabled or removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we should just remember to re-enable it when the cluster is fixed.
Gitlab is currently completely broken and unusable. Hence we deactivate it until it can be used.
Gitlab is currently completely broken and unusable. Hence we deactivate it until it can be used.