Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement diam and area. #1323

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Implement diam and area. #1323

merged 3 commits into from
Jul 8, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Jun 17, 2024

No description provided.

@1uc
Copy link
Collaborator Author

1uc commented Jun 17, 2024

The SEGFAULT is expected until we merge: neuronsimulator/nrn#2914

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.35%. Comparing base (7910146) to head (660124f).

Files Patch % Lines
src/codegen/codegen_neuron_cpp_visitor.cpp 27.27% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1323      +/-   ##
==========================================
- Coverage   85.37%   85.35%   -0.03%     
==========================================
  Files         178      178              
  Lines       13459    13462       +3     
==========================================
- Hits        11491    11490       -1     
- Misses       1968     1972       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@1uc 1uc closed this Jun 18, 2024
@1uc 1uc reopened this Jun 18, 2024
@bbpbuildbot

This comment has been minimized.

@1uc 1uc closed this Jun 18, 2024
@1uc 1uc reopened this Jun 18, 2024
@bbpbuildbot

This comment has been minimized.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jun 27, 2024
@bbpbuildbot

This comment has been minimized.

@1uc 1uc marked this pull request as ready for review June 27, 2024 16:00
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jul 8, 2024
@bbpbuildbot

This comment has been minimized.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jul 8, 2024
Copy link
Contributor

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #220792 (:white_check_mark:) have been uploaded here!

Status and direct links:

@pramodk pramodk merged commit a209d0a into master Jul 8, 2024
23 checks passed
@pramodk pramodk deleted the 1uc/morphology branch July 8, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants