Install pywrapper even as a submodule. #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jul 11, 2024
|
Logfiles from GitLab pipeline #221353 (:no_entry:) have been uploaded here! Status and direct links: |
Should avoid the upstream CMake having to deal with installing NMODL internals.
matz-e
force-pushed
the
install-pywrapper-ourselves
branch
from
5d3b218
to
c2c7889
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1337 +/- ##
=======================================
Coverage 86.71% 86.71%
=======================================
Files 180 180
Lines 13699 13699
=======================================
Hits 11879 11879
Misses 1820 1820 ☔ View full report in Codecov by Sentry. |
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Aug 13, 2024
matz-e
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Aug 14, 2024
alkino
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should avoid the upstream CMake having to deal with installing NMODL
internals.