Refactor print_namespace_{start,stop}. #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1uc
force-pushed
the
1uc/refactor-print_namespace
branch
2 times, most recently
from
41085b6
to
eda6a63
Compare
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jul 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1380 +/- ##
=======================================
Coverage 86.81% 86.81%
=======================================
Files 180 180
Lines 13670 13671 +1
=======================================
+ Hits 11868 11869 +1
Misses 1802 1802 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
JCGoran
approved these changes
Jul 31, 2024
1uc
force-pushed
the
1uc/refactor-print_namespace
branch
from
eda6a63
to
9db9c49
Compare
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Aug 5, 2024
|
Logfiles from GitLab pipeline #224870 (:white_check_mark:) have been uploaded here! Status and direct links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the only thing that differs is the name of the namespace, we're better off adding a virtual method for the namespace name, and devirtualize the printing of
namespace {} {.