Test side effects in KINETIC blocks. #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Effectively the side effects in KINETIC blocks, such as assigning a STATE to a RANGE variable happen (once more) after the state has been updated. This commit adds test for this; and "fixes" the bug by running the functor method `initialize` again after running Newton.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1392 +/- ##
=======================================
Coverage 86.75% 86.75%
=======================================
Files 180 180
Lines 13669 13670 +1
=======================================
+ Hits 11858 11859 +1
Misses 1811 1811 ☔ View full report in Codecov by Sentry. |
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Aug 9, 2024
nrnhines
approved these changes
Aug 10, 2024
1uc
changed the title
|
The solution is ugly. Hence, we need to revisit it. The issue is: #1391. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effectively the side effects in KINETIC blocks, such as assigning a STATE to a RANGE variable happen (once more) after the state has been updated.
This commit adds test for this; and "fixes" the bug by running the functor method
initializeagain after running Newton.