-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Catch 2 to a v3 version #973
Conversation
Just something I quickly noticed. Should the function table changes be in separate PR? |
7a942c3
to
f377978
Compare
cf1465d
to
576ae1e
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't spot anything in the diff, but the failing CI needs to be understood...
(Slack is down) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4b3ece7
to
7971732
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #973 +/- ##
==========================================
+ Coverage 69.93% 69.95% +0.02%
==========================================
Files 188 188
Lines 25639 25639
==========================================
+ Hits 17931 17937 +6
+ Misses 7708 7702 -6
|
Alléluïa |
Logfiles from GitLab pipeline #125202 (:white_check_mark:) have been uploaded here! Status and direct links: |
A lot of changes are needed because they break how catch2 from v2 to v3.
First of all, this is no more header-only but as a static library now.
Headers are split for compilation speed.