Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As an analyst, go to line number should be supported, to make it faster to find content. #150

Closed
2 tasks
Pressacco opened this issue May 23, 2021 · 0 comments · Fixed by #174, #201, #203 or #207
Closed
2 tasks

As an analyst, go to line number should be supported, to make it faster to find content. #150

Pressacco opened this issue May 23, 2021 · 0 comments · Fixed by #174, #201, #203 or #207
Labels
user_story Represents a proposed feature/enhancement. Includes enough detail to be a conversation starter.
Milestone
Sprint 2.8 : Navi...

Comments

@Pressacco
Copy link
Member

Pressacco commented May 23, 2021 •
edited

Acceptance criteria:

  • be able to enter: 1,234
  • be able to enter: 1234

Relates To

The Timestamp and LineNumber navigation share common code... so commits for these features have been added to both Git issues:
@Pressacco Pressacco added the user_story Represents a proposed feature/enhancement. Includes enough detail to be a conversation starter. label May 29, 2021
@Pressacco Pressacco added this to the 2.8.0 milestone Jun 30, 2021
BlueDotBrigadeFounder pushed a commit that referenced this issue Jul 2, 2021
@Pressacco
Refactor : renamed class to FindTextNavigator to clarify intent #150
a944159
BlueDotBrigadeFounder pushed a commit that referenced this issue Jul 2, 2021
@Pressacco
Refactor : renamed GoToNavigator #150
8866008
BlueDotBrigadeFounder pushed a commit that referenced this issue Jul 2, 2021
@Pressacco
New : can now GoTo a given line number. #150
746a1a9
BlueDotBrigadeFounder pushed a commit that referenced this issue Jul 2, 2021
@Pressacco
Refactor : renamed navigation interfaces to help clarify intent. #150
861e248
@Pressacco Pressacco mentioned this issue Jul 2, 2021
Merged
BlueDotBrigadeFounder pushed a commit that referenced this issue Jul 10, 2021
@Pressacco
Refactor : _metricCollectors field was renamed. The name was not in…
ae69eeb 
…line with the underlying type. And removed dead code. #150
BlueDotBrigadeFounder pushed a commit that referenced this issue Jul 10, 2021
@Pressacco
New: minor improvement to the GUI #150
2d1c4a3
BlueDotBrigadeFounder pushed a commit that referenced this issue Jul 11, 2021
@Pressacco
Refactor : improving the readability of the navigator classes #150
169932c
BlueDotBrigadeFounder pushed a commit that referenced this issue Jul 11, 2021
@Pressacco
Refactor : trying to make the intent more clear re: `LineNumberNaviga…
0b4a8ac 
…tor` #150
BlueDotBrigadeFounder pushed a commit that referenced this issue Jul 11, 2021
@Pressacco
Refactor : simplifiying the LineNumberNavigator #150
bf9642d
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 2, 2021
@Pressacco
New : improved find/goto message box prompt #150
a910556
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 2, 2021
@Pressacco
Fix : RecordNavigator did not initialize _activeRecord #150
366dea2
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 2, 2021
@Pressacco
New : User now told when GoTo unable to find record #150
a4d08a0
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 2, 2021
@Pressacco
New : User now told when GoTo unable to find record #150
4805977
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 2, 2021
@Pressacco
Refactor : To simplify unit tests created a R class to generate fak…
579fbf1 
…e records. Ultimately all but one constructor will be removed from `Record`. #150
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 2, 2021
@Pressacco
Refactor : now use IndexOfLineNumber() extension method instead of …
dc6cce0 
…explicitliy creating `RecordLineComparer` for `BinarySearch()` #150
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 2, 2021
@Pressacco
Fix : integration tests caught a bug... a Clear() operation returne…
e495665 
…d the wrong selected records. #150
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 2, 2021
@Pressacco
Fix : Integration test had incorrectly selected a record that did not…
1ffe013 
… exist. Re-wrote test to be more inline with the intent: filter history should remain intact after `Clear()` operation. #150
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 2, 2021
@Pressacco
New : Created a BinarySearchHelper that supports finding the `Close…
98bfb6d 
…stMatch` to the given line number. #150
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 2, 2021
@Pressacco
Test : added additional integration tests for pinned records #150
d3853b4
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 2, 2021
@Pressacco
Doc : Clarifying intent re: navigation interfaces. #150
ab0c427
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 2, 2021
@Pressacco
Fix : various improvements to the generic RecordNavigator. #150
95e96a4
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 2, 2021
@Pressacco
New : making improvments to the LineNumberNavigator and `TimeStampN…
d44616f 
…avigator`... in preparation for `ClosestMatch` support. #150
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 2, 2021
@Pressacco
New : the R record factory can now create a collection of records #150
d8caca8
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 2, 2021
@Pressacco
Test : improving the navigation related unit tests #150
38ad123
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 2, 2021
@Pressacco
Test : fixed a SelectionManager unit test #150
aad6eb0
@Pressacco Pressacco mentioned this issue Oct 2, 2021
Closed
2 tasks
@Pressacco Pressacco mentioned this issue Oct 6, 2021
Merged
@Pressacco Pressacco linked a pull request Oct 6, 2021 that will close this issue
To main for: supporting GoTo line number & timestamp #201
Merged
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 8, 2021
@Pressacco
Test : added unit tests for RecordNavigator #150
90e6f83
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 8, 2021
@Pressacco
Fix : Searching for text will now catch the newly created `RecordNotF…
0ec57b3 
…ound` exception. #150
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 8, 2021
@Pressacco
New : BinarySearchHelper now includes IndexOfCreatedAt(DateTime) #…
eb6e7f2 
…150
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 8, 2021
@Pressacco
New : R can now create fake records with a given CreatedAt of typ…
a10bda1 
…e `DateTime`. #150
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 8, 2021
@Pressacco
New : GoTo the closest CreatedAt timestamp now works. #150
18bc515
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 8, 2021
@Pressacco
Test : added unit tests for TimestampNavigator. #150
e859bb6
@Pressacco Pressacco mentioned this issue Oct 8, 2021
Merged
@Pressacco Pressacco linked a pull request Oct 8, 2021 that will close this issue
Merge to main for supporting: GoTo the closest CreatedAt timestamp. #203
Merged
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 8, 2021
@Pressacco
Fix : User is now informed if the GoTo specified timestamp fails. #150
38fadf8
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 8, 2021
@Pressacco
Fix : errors in RecordNavigator #150
f2bdd16
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 8, 2021
@Pressacco
New : Improved user feedback re: GoTo errors. #150
d8f0a8f
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 9, 2021
@Pressacco
Refactor : Introduced a MagnitudeComparer to BinarySearchHelper i…
17236e1 
…n order to remove redundant code. #150
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 10, 2021
@Pressacco
New : Created shared TestingTools library #150.
daf24f9
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 10, 2021
@Pressacco
Refactor : BinarySearchHelper is now called RecordSearch. #150
001ec56
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 10, 2021
@Pressacco
Test : Moved unit tests closer to RecordSearch where they belong. #150
0ae5ecc
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 10, 2021
@Pressacco
New : Created a GoTo dialog box. #150
403d7be
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 10, 2021
@Pressacco
New : GoTo line number now defaults to ClosestMatch. #150
199c8ff
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 10, 2021
@Pressacco
Doc : Clarifying the intent of RecordSearch implementation. #150
634f372
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 19, 2021
@Pressacco
Refactor : Removed duplicate code. #150.
5b75d2b
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 19, 2021
@Pressacco
New : Debug build configuration no longer builds the Setup projec…
3c55816 
…ts. #150
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 19, 2021
@Pressacco
Refactor : RecordSearch related code has been moved into the `Navig…
58df3aa 
…ation` namespace. #150
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 19, 2021
@Pressacco
Refactor : RecordNavigator is now called ActiveRecord #150
518908e
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 19, 2021
@Pressacco
Refactor : Moved binary search comparers to Navigation. #150
06277ae
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 19, 2021
@Pressacco
Refactor : Clear separation between RecordExtensions and `RecordSea…
9b10637 
…rch`. #150
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 19, 2021
@Pressacco
Refactor : moved all IRecord extension methods into the Data name…
beaf942 
…space. #150
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 19, 2021
@Pressacco
Refactor : Moved RecordCollectionExtensions into the appropriate cl…
3722218 
…ass, and removed duplicate code. #150
BlueDotBrigadeFounder pushed a commit that referenced this issue Oct 19, 2021
@Pressacco
Refactor : Decoupled search methods from ActiveRecord. #150.
78cd23c
@Pressacco Pressacco linked a pull request Oct 19, 2021 that will close this issue
Merge branch to main for: improved GoTo & Find support #207
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
user_story Represents a proposed feature/enhancement. Includes enough detail to be a conversation starter.
Projects
None yet
Milestone
Sprint 2.8 : Navigation
1 participant
@Pressacco