Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trial an update to Mono 3.10.0 #278

Closed
wants to merge 9 commits into from
Closed

Trial an update to Mono 3.10.0 #278

wants to merge 9 commits into from

Conversation

dsyme
Copy link
Member

@dsyme dsyme commented Nov 1, 2014

No description provided.

@dsyme
Copy link
Member Author

dsyme commented Nov 1, 2014

OK, yes, the main problem is the failure in Array.dropRange. The following coe makes 19 out of 20 errors go away:

  let inline dropRange first last (data:'T[]) =
    if last < first then invalidOp "The first index must be smaller than or equal to the last."
    if first < 0 || last >= data.Length then invalidArg "first" "The index must be within the array range."
    Array.append (if first = 0 then [| |] else data.[.. first - 1]) (if last = data.Length - 1 then [| |] else data.[last + 1 ..])

There is another error in testing the documentation creation which is an FSharp.Data not found error. I think this is much less serious and you could probably just disable that test on Mono since I think you build docs on Windows anyway.

@dsyme
Copy link
Member Author

dsyme commented Nov 2, 2014

Closed in favour of this: #282

@dsyme dsyme closed this Nov 2, 2014
tpetricek added a commit to tpetricek/Deedle that referenced this pull request Nov 2, 2014
…slaborg#278

Aside from changing the Travis config file, this incorporates the
fix from @dsyme (fslaborg#279) and then it makes the documentation tests
pass - not quite sure why this works though (see fslaborg#280).
tpetricek added a commit that referenced this pull request Nov 3, 2014
Update Mono version & cleans up and aggregates fixes #279 and #278
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant