Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Travis update to Mono 3.2.8 #275

Closed
wants to merge 2 commits into from
Closed

Testing Travis update to Mono 3.2.8 #275

wants to merge 2 commits into from

Conversation

dsyme
Copy link
Member

@dsyme dsyme commented Oct 7, 2014

No description provided.

@adamklein
Copy link
Contributor

@tpetricek FYI the failures in the associated Travis CI build above are exactly what I was seeing when I test/built locally on Mac OSX using Xamarin Studio's mono.

@tpetricek
Copy link
Member

Sadly, I don't have a Mac to try this myself at the moment - @dsyme do you have and idea what might be causing this?

@dsyme
Copy link
Member Author

dsyme commented Nov 1, 2014

Looking at the log, all the errors except one look like this:

System.IndexOutOfRangeException : Array index is out of range.
at Deedle.Vectors.ArrayVector.ArrayVectorBuilder.Deedle-Vectors-IVectorBuilder-Build[IVector]

The "Build" implementation of IVectorBuilder is pretty long. I notice a lot of array accesses in that, but also a couple of array slices. One possible cause is an F# 3.x change to give consistency in raising IndexOutOfRangeException when a negative index is used in a slicing range s1.[.. -1], see fsharp/fsharp@d8ee80f.

But I suspect some broken array indexing in that method. It might be necessary to adjust this PR to put some post-hoc logging into that method at each array access or array slice to try to work out what's wrong

Thre is also a test failure bout producng documentation where FSHarp.Data is not found. But I'd recommend fixing the IndexOutOfRange exception first.

@dsyme
Copy link
Member Author

dsyme commented Nov 1, 2014

Trialling some logging and a 3.10.0 update here: #278

@dsyme
Copy link
Member Author

dsyme commented Nov 1, 2014

Let's continue the discussion on that thread - #278

@dsyme dsyme closed this Nov 1, 2014
@dsyme
Copy link
Member Author

dsyme commented Nov 1, 2014

OK, see #278, #279 and #280

@dsyme
Copy link
Member Author

dsyme commented Nov 1, 2014

After #279 and #280 are accepted, the travis update in #278 should be made (but do not accept #278 since it contains all the logging junk)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants