Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New quirks for "X68000" #102

Closed
wants to merge 8 commits into from
Closed

New quirks for "X68000" #102

wants to merge 8 commits into from

Conversation

aotta
Copy link
Contributor

@aotta aotta commented Dec 23, 2023

I added a new quirks "X68000" to handle some errors on non-standard "00" commands.
It solved loading errors in several games / program that loaded fine with older ArdSCSIno firmware

@erichelgeson
Copy link
Contributor

Thank you for digging into this and providing a patch!

Could you add it to this method too? https://github.com/BlueSCSI/BlueSCSI-v2/blob/main/src/BlueSCSI.cpp#L201

Notes from Discord:
This is an observed behavior - since the SASI docs are difficult to find/read (in JP mainly) - if we could find a spec that verifies this behavior it would be best.
Looking at PiSCSI they seem to not check the control bit so thats why theirs works with SASI/X68K machines.

@aotta
Copy link
Contributor Author

aotta commented Dec 23, 2023

Could you add it to this method too? https://github.com/BlueSCSI/BlueSCSI-v2/blob/main/src/BlueSCSI.cpp#L201

i already added the update for BlueSCSI.cpp in pull, i missed something?

Notes from Discord: This is an observed behavior - since the SASI docs are difficult to find/read (in JP mainly) - if we could find a spec that verifies this behavior it would be best. Looking at PiSCSI they seem to not check the control bit so thats why theirs works with SASI/X68K machines.

Well, i didn't find any docs about the two non standard call, but for sure it's not enough in V2 to simply pass status "good" for both calls, since i had errors it that ways (even if it's strange since ArcSCSIno - that works fine with SASI - seems to handle all 0x00 commands with "no sense" and "good").
The patch i propose it's in fact a bit "empiric" but it works fine so far.

erichelgeson pushed a commit that referenced this pull request Jan 14, 2024
@erichelgeson
Copy link
Contributor

I squashed and cleaned up some white space and cherry picked it in via aa77d67 - thanks again!

morio added a commit to ZuluSCSI/ZuluSCSI-firmware that referenced this pull request Jan 22, 2024
Fix by @aotta
BlueSCSI/BlueSCSI-v2#102

Adds a new quirk setting to `zuluscsi.ini` which should be applied by
setting
```
[SCSI]
System = X68000
```
but can also be applied by setting
```
[SCSI]
Quirks = 16
```

Apparently X68000 system send a SCSI opcode 0x00 which is normally
an error. This quirk setting catches the opcode and sends the
proper response.

Co-authored-by:  Andrea Ottaviani <andrea.ottaviani.69@gmail.com>
morio added a commit to ZuluSCSI/ZuluSCSI-firmware that referenced this pull request Jan 22, 2024
Fix by @aotta
BlueSCSI/BlueSCSI-v2#102

Adds a new quirk setting to `zuluscsi.ini` which should be applied by
setting
```
[SCSI]
System = X68000
```
but can also be applied by setting
```
[SCSI]
Quirks = 16
```

Apparently X68000 system send a SCSI opcode 0x00 which is normally
an error. This quirk setting catches the opcode and sends the
proper response.

Co-authored-by:  Andrea Ottaviani <andrea.ottaviani.69@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants