Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scsi: fix mac vendor page #134

Merged
merged 1 commit into from
Apr 3, 2024
Merged

scsi: fix mac vendor page #134

merged 1 commit into from
Apr 3, 2024

Commits on Apr 2, 2024

  1. scsi: fix mac vendor page

    In SCSI2SD 4.1.1 circa 2015 c09e15b there was a bug introduced that incorrectly checked the allocation length of the Apple Vendor page. This worked as it was silently truncating the response. But did cause the vendor string to always be sent even if Apple Quirks was disabled.
    
    In upstream 0abf488 an attempt was made to fix this, but it was not tested with Apple’s formatting utilities as it does not work.
    
    After validating with multiple real apple firmware drives the correct behavior is to truncate the page. This is the same behavior as every other page being sent. Note newer drives page code is actually this longer variant but older ones have a shorter length. The Apple formatting tools ignore the page length field when doing their checks so was left as the longer variant, truncated.
    erichelgeson committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    6c8a264 View commit details
    Browse the repository at this point in the history