Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Keystone xpub/ypub (besides zpub) #5281

Closed
Overtorment opened this issue Jan 21, 2023 · 1 comment
Closed

Add support for Keystone xpub/ypub (besides zpub) #5281

Overtorment opened this issue Jan 21, 2023 · 1 comment
Assignees

Comments

@Overtorment
Copy link
Member

We're planing to support BlueWallet and other bitcoin wallets in our multi-coin firmware to make bitcoin accessible for more users.
In order to do this and support more use cases, we plan to put p2pkh xpub, p2sh ypub and p2wpkh zpub into the CryptoAccount QR code, so users can select which key to use when they connect Keystone to WatchOnly wallets.
Currently in the btc-only firmware, we just put p2wpkh zpub into the CryptoAccount while BlueWallet just take the first account in the account list and assumes it is a zpub. So we will put the keys in the order [zpub, ...other keys] to avoid compatible issues.
So we need your help to improve this change 🙂. We really appreciate it if you can support xpub and ypub in the BlueWallet for Keystone and add a step to let user select which key to use when importing keys. Sparrow has already support this maybe it can be a reference.

@soralit
Copy link

soralit commented Jan 29, 2023

Hi @Overtorment , thanks for adding this.
Just list an example QR code here:
image

It contains keys in order:

  1. wpkh([73c5da0a/84'/0'/0']xpub6CatWdiZiodmUeTDp8LT5or8nmbKNcuyvz7WyksVFkKB4RHwCD3XyuvPEbvqAQY3rAPshWcMLoP2fMFMKHPJ4ZeZXYVUhLv1VMrjPC7PW6V/0/*)
  2. sh(wpkh([73c5da0a/49'/0'/0']xpub6C6nQwHaWbSrzs5tZ1q7m5R9cPK9eYpNMFesiXsYrgc1P8bvLLAet9JfHjYXKjToD8cBRswJXXbbFpXgwsswVPAZzKMa1jUp2kVkGVUaJa7/0/*))
  3. pkh([73c5da0a/44'/0'/0']xpub6BosfCnifzxcFwrSzQiqu2DBVTshkCXacvNsWGYJVVhhawA7d4R5WSWGFNbi8Aw6ZRc1brxMyWMzG3DSSSSoekkudhUd9yLb6qx39T9nMdj/0/*)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants