Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor classes #972

Closed
Overtorment opened this issue Apr 10, 2020 · 4 comments
Closed

Refactor classes #972

Overtorment opened this issue Apr 10, 2020 · 4 comments

Comments

@Overtorment
Copy link
Member

Wallets go to a separate folder.
Camelcase filenames change to snake case

@mgurzenski
Copy link
Contributor

I can work on this.

@mgurzenski
Copy link
Contributor

For "wallets go to a separate folder" - are you thinking the "wallets" folder would be a child or a sibling to the "class" folder?

For "camelcase filenames change to snake case":

  1. Do you want just the files in the folder named "class" renamed or all files in the project (i.e. files within the models, screens, tests folders also)?
  2. Should kebab-case filenames also be changed to snake_case (i.e. legacy-wallet.js -> legacy_wallet.js)?

@Overtorment
Copy link
Member Author

Overtorment commented May 20, 2020 via email

@Overtorment
Copy link
Member Author

#1142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants