-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor classes #972
Labels
Comments
I can work on this. |
For "wallets go to a separate folder" - are you thinking the "wallets" folder would be a child or a sibling to the "class" folder? For "camelcase filenames change to snake case":
|
Oh I actually meant kebab-case. Most of them already are.
And “wallets/“ should be inside “classes/“.
🙏 thanks!
…On Wed, 20 May 2020 at 21:00, Matt Gurzenski ***@***.***> wrote:
For "wallets go to a separate folder" - are you thinking the "wallets"
folder would be a child or a sibling to the "class" folder?
For "camelcase filenames change to snake case":
1. Do you want just the files in the folder named "class" renamed or
all files in the project (i.e. files within the models, screens, tests
folders also)?
2. Should kebab-case filenames also be changed to snake_case (i.e.
legacy-wallet.js -> legacy_wallet.js)?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#972 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOTD6PPDW3LJ27HZAQ2CEDRSQZGDANCNFSM4MFUALJQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Wallets go to a separate folder.
Camelcase filenames change to snake case
The text was updated successfully, but these errors were encountered: