Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Electrum recovery bug #1046

Merged
merged 3 commits into from
May 4, 2020
Merged

Fix Electrum recovery bug #1046

merged 3 commits into from
May 4, 2020

Conversation

junderw
Copy link
Collaborator

@junderw junderw commented May 4, 2020

Note: This can be a potentially breaking change in the following scenario:

  1. User creates segwit wallet in Electrum.
  2. User imports the seed into BlueWallet.
  3. BlueWallet will use the seed to generate a legacy wallet when the seed's version prefix is not legacy.
  4. Patched version will suddenly break it for them.

TBH I think the number of users using this is small enough to just patch it and help them out when they create an issue.

@junderw junderw requested a review from Overtorment May 4, 2020 00:19
@GladosBlueWallet
Copy link
Collaborator

♫ This was a triumph. I'm making a note here: HUGE SUCCESS ♫

[android in browser] https://appetize.io/app/k35qqj93gbe5ptyhmczj1v5bw4

download apk

@junderw junderw added bug Something isn't working electrum labels May 4, 2020
@junderw
Copy link
Collaborator Author

junderw commented May 4, 2020

I published v2.0.0 of the electrum-mnemonic library with a new validateMnemonic that doesn't use mnemonicToSeed, and I changed the API to take an optional prefix for mnemonicToSeed instead of validPrefixes with all valid prefixes.

@GladosBlueWallet
Copy link
Collaborator

♫ This was a triumph. I'm making a note here: HUGE SUCCESS ♫

[android in browser] https://appetize.io/app/94yht7gejkdxr3kvq4bf7xgrur

download apk

@junderw
Copy link
Collaborator Author

junderw commented May 4, 2020

Circle CI build keeps failing at unrelated parts.

@GladosBlueWallet
Copy link
Collaborator

♫ This was a triumph. I'm making a note here: HUGE SUCCESS ♫

[android in browser] https://appetize.io/app/8yfqrj925ajz36v1cctd06dat0

download apk

@junderw junderw mentioned this pull request May 4, 2020
@Overtorment Overtorment merged commit 6100a9a into master May 4, 2020
@Overtorment Overtorment deleted the fixElectrumBug branch May 4, 2020 10:39
@Overtorment
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working electrum
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants