Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalization – Part One #2289

Merged
merged 3 commits into from Dec 9, 2020
Merged

Capitalization – Part One #2289

merged 3 commits into from Dec 9, 2020

Conversation

mcsaeid
Copy link
Contributor

@mcsaeid mcsaeid commented Dec 8, 2020

Please note that these changes are not specific to one English style guide. These are what all style guides agree upon. Most of these words or phrases are titles. Let me know which one does not make sense for you, and I will provide links that you can read and make an informed decision. The rest will be changed in part two.

Please note that these changes are not specific to one English style guide. These are what all style guides agree upon. Most of these words or phrases are titles. Let me know which one does not make sense for you, and I will provide links that you can read and make an informed decision. The rest will be changed in part two.
Copy link
Member

@Overtorment Overtorment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

json is broken. you can validate it on https://jsonparseronline.com

@mcsaeid
Copy link
Contributor Author

mcsaeid commented Dec 8, 2020

Thank you for the tip.

What do you think now?

@Overtorment
Copy link
Member

its a valid json now

@Overtorment
Copy link
Member

some strings werent capitalized probably because contextually, they looked better without capitalization. for example:

image

image

image

image

@mcsaeid
Copy link
Contributor Author

mcsaeid commented Dec 8, 2020

Contextually, titles should be capitalized regardless of how they look. That is why we have rules in writing. Styles make sense as long as there is consistency. Here is an example of inconsistency. In the second screenshot, you have “window” and “mix / max,” both of which are not capitalized, but then you have “Cash.”

Aside from how they all look, it is not common at all. If you look closely at every major app or platform, wherever capitalization is called for, it is there—not because it looks right but because there is a certain style guide that was followed.

Instagram

Even in the cases that you mentioned and provided screenshots for, as someone who specializes in writing and editing, I still believe revision is the way to go. However, the final call is yours. I am only here to make things better.

@Overtorment
Copy link
Member

@ncoelho

@ncoelho ncoelho removed the WIP label Dec 9, 2020
@Overtorment
Copy link
Member

pls fix conflicts

@marcosrdz marcosrdz merged commit f4d1a76 into BlueWallet:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants