ADD: lightning address send support (closes #3690) #3717
Conversation
|
♫ This was a triumph. I'm making a note here: HUGE SUCCESS ♫ [android in browser] https://appetize.io/app/f95hct90u728vjmbav5g73xaqw?device=pixel4 |
| setLN(ln); | ||
| setIsLoading(false); | ||
| } | ||
| }, [lnurl]); | ||
| }, [lnurl, pop]); |
There was a problem hiding this comment.
Don't think pop needs to be in useEffect dependencies as its not something we need to keep track of. what do u think @limpbrains ?
There was a problem hiding this comment.
eslint complained that its not on deps list, so I added.
don't really understand whats going on here
There was a problem hiding this comment.
I think it is better to follow eslint react-hooks/exhaustive-deps rule and list all deps in array, like it is here.
Especially if you don't know whats going on :)
I hope react-navigation doesn't mutate pop() too often
|
Good catch. Will patch it later
…On Mon, 30 Aug 2021 at 21:27, Ivan ***@***.***> wrote:
***@***.**** approved this pull request.
According to code asdasd @Domain is a valid address. I guess it's ok.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3717 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOTD6I3W3FRYNLDAU5IXHLT7PSULANCNFSM5DCJ4C4Q>
.
|
|
Unbelievable. You, [subject name here], must be the pride of [subject hometown here]! |
|
nice, thank you |
No description provided.