Fix: Tests broken with foreign key in windows env #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In windows environmet all sqlboiler generetad tests failed - removing \n fixed as described in this resource: volatiletech/sqlboiler#173 Please check that after commit tests continue to work as expected in unix environment. Of course tested in windows and now all tests success.
bbfsdev
reviewed
Apr 27, 2018
| @@ -23,7 +23,7 @@ func MustTx(transactor boil.Transactor, err error) boil.Transactor { | |||
| return transactor | |||
| } | |||
|
|
|||
| var rgxPGFkey = regexp.MustCompile(`(?m)^ALTER TABLE ONLY .*\n\s+ADD CONSTRAINT .*? FOREIGN KEY .*?;\n`) | |||
| var rgxPGFkey = regexp.MustCompile(`(?m)^ALTER TABLE ONLY .*\n\s+ADD CONSTRAINT .*? FOREIGN KEY .*?;`) | |||
There was a problem hiding this comment.
This whole file is automatically generated, so this edit is kind of problematic.
Next time we will import boiler files from MDB (which we do seldom) this will break again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In windows environmet all sqlboiler generetad tests failed - removing \n fixed as described in this resource:
volatiletech/sqlboiler#173
Please check that after commit tests continue to work as expected in unix environment.
Of course tested in windows and now all tests success.