builder: catch the correct CancelledError #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The asyncio.CancelledError class was the same as concurrent.futures.CancelledError in the past. Recently it was converted to its own class, leading to visible backtraces.
Codecov Report
@@ Coverage Diff @@
## master #425 +/- ##
=======================================
Coverage 82.46% 82.46%
=======================================
Files 42 42
Lines 13569 13569
=======================================
Hits 11190 11190
Misses 2379 2379
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The asyncio.CancelledError class was the same as
concurrent.futures.CancelledError in the past. Recently it was converted
to its own class, leading to visible backtraces.