Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require Guzzle7 extra for MODX 3 #85

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

bezumkin
Copy link

MODX 3 already has guzzlehttp/guzzle as composer dependency in core/vendor directory.

We don't need to require additional extra with different version of Guzzle.

@BobRay
Copy link
Owner

BobRay commented Mar 23, 2024

I'm working on a new version that won't use either Guzzle or cURL. It uses MODX internal functions to generate the cache files. It's much faster and better, but it still has some strange issues I have to work out. Let me know if you'd like to be a beta tester.

@bezumkin
Copy link
Author

@BobRay Sure I would like to test the beta, but my point was to quickly release this update to help people to get rid of Guzzle7 in MODX 3.

Because it may cause conflicts.

@BobRay
Copy link
Owner

BobRay commented Mar 24, 2024

Thanks, I'll put it up for you when I have something worth testing.

@BobRay
Copy link
Owner

BobRay commented Apr 5, 2024

@BobRay Sure I would like to test the beta, but my point was to quickly release this update to help people to get rid of Guzzle7 in MODX 3.

Because it may cause conflicts.

I'm hoping it's about ready to release. The transport file for the 3.0.1-beta is in the dev branch HERE.

If you don't find any problems let me know and I'll release it. Thanks for the help!

Bob

@Mark-H
Copy link

Mark-H commented Apr 24, 2024

Fwiw, the issue in guzzle7 is fixed in v7.8.1. See my comment here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants