Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate signature display on Kobo 4.24.15676 #143

Closed
BoboTiG opened this issue Sep 26, 2020 · 4 comments · Fixed by #193
Closed

Investigate signature display on Kobo 4.24.15676 #143

BoboTiG opened this issue Sep 26, 2020 · 4 comments · Fixed by #193
Labels
bug Something isn't working

Comments

@BoboTiG
Copy link
Owner

BoboTiG commented Sep 26, 2020

See #142 for some details. I need to upgrade to Kobo 4.24.15676 and check what can be done to get back a normal behavior.

The current behavior is that if the Zip is copied into .kobo/dict it will display both signatures:

Wiktionnaire (c) 2020
Le Robert Micro (C) 2013 Dictionnaires Le Robert

But it works correctly when copied into .kobo/custom-dict. However, the orginal dictionary (Le Robert) is used by default and it is not convenient to select the Wiktionary dict every time.

@BoboTiG BoboTiG added the bug Something isn't working label Sep 26, 2020
@lasconic
Copy link
Collaborator

lasconic commented Nov 7, 2020

This is also promising no ? pgaskin/dictutil#14 (comment)

A custom credit line can be added to the bottom of all entries in the dictionary (newline then the text in italics) by setting it as the zip global archive comment.

@lasconic
Copy link
Collaborator

lasconic commented Nov 7, 2020

I just tested and it works for both dict/customdict and both for the in-book dictionary and the search. I'm running 4.24.15676.
I removed the hack from and the source line from "WORD_FORMAT" and added the zipfile comment.

What's your policy in term of firmware support?

@lasconic
Copy link
Collaborator

lasconic commented Nov 7, 2020

For reference: see PR #193
Interestingly the French dictionary looses ~200kB.

@BoboTiG
Copy link
Owner Author

BoboTiG commented Nov 8, 2020

Indeed, that's exactly what I was thinking for the fix. And getting rid of the hack is soo attractive :)

I have no policy , mostly because I have no numbers (which firmware versions are in use?). But I think losing the signature on old ones is not an issue.

I have a similar dilemma with #54 but maybe can we generate 2 dictionaries (one for < 4.24 and for for >= 4.24).

BoboTiG pushed a commit that referenced this issue Nov 8, 2020
That means the dictionary signature will not be the good one on firmwares < 4.24 but we need to move forward, this is not a big deal.

Getting rid of the signature hack is also a good thing IMO: smaller HTML data to extract for each and every word, smaller dictionary size, better code readability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants