-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate signature display on Kobo 4.24.15676 #143
Comments
This is also promising no ? pgaskin/dictutil#14 (comment)
|
I just tested and it works for both dict/customdict and both for the in-book dictionary and the search. I'm running 4.24.15676. What's your policy in term of firmware support? |
For reference: see PR #193 |
Indeed, that's exactly what I was thinking for the fix. And getting rid of the hack is soo attractive :) I have no policy , mostly because I have no numbers (which firmware versions are in use?). But I think losing the signature on old ones is not an issue. I have a similar dilemma with #54 but maybe can we generate 2 dictionaries (one for < 4.24 and for for >= 4.24). |
That means the dictionary signature will not be the good one on firmwares < 4.24 but we need to move forward, this is not a big deal. Getting rid of the signature hack is also a good thing IMO: smaller HTML data to extract for each and every word, smaller dictionary size, better code readability.
See #142 for some details. I need to upgrade to Kobo 4.24.15676 and check what can be done to get back a normal behavior.
The current behavior is that if the Zip is copied into
.kobo/dict
it will display both signatures:But it works correctly when copied into
.kobo/custom-dict
. However, the orginal dictionary (Le Robert) is used by default and it is not convenient to select the Wiktionary dict every time.The text was updated successfully, but these errors were encountered: