Keep the whole etymology

[BoboTiG]

• Wiktionary page: https://fr.wiktionary.org/wiki/bath

Command:

python -m scripts --locale="fr" --get-word="bath" 

Output:

bath \bat\ (m.) 

(Adjectif, nom 1) (1846) Origine discutée : 

  1. (Argot) (Désuet) Super ; bon ; agréable.
  2. Papier à lettre de provenance anglaise, de belle qualité, qui a joui d’une grande vogue au XIXème siècle.
  3. Mesure des liquides chez les Hébreux, valant 18,08 litres puis plus tard environ 38,88 litres.

The etymology is clearly truncated. It has a sublist and even a second etymology.

Not a big priority, I just opened the issue to keep the track.

[BoboTiG]

Another one: https://fr.wiktionary.org/wiki/picotin

[lasconic]

https://fr.wiktionary.org/wiki/%C3%A0_minima

[lasconic]

Also https://fr.wiktionary.org/wiki/non-r%C3%A9sistance

Is it for french only ?

[lasconic]

I had a quick look. It seems we would need etymology to become a list of list (of list ?) just like Definitions. Maybe we could even reuse this type for etymology. WDYT ?
I might have a try in the coming week.

[BoboTiG]

Yes, we could reuse Definitions 👍

[BoboTiG]

I did not encounter complex etymologies on other locales, but I am not using other dictionaries. I would vote to fix etymologies for all locales.

[lasconic]

[lasconic]

Is this rendering ok ?

[BoboTiG]

It seems nice.
Do you think we should find a way to differentiate the etymology from definitions?

[BoboTiG]

We could go like that and eventually adjust the rendering later (let's see how it works for us on a day-to-day basis), WDYT?

[lasconic]

Sure. Some etymologies are crazy btw : https://fr.wiktionary.org/wiki/marron

I'm still working on the tests. PR to come.

[BoboTiG]

Wow, I really hope that such etymolgy is rare enough to not mimic the "Le Littré" (where it becomes really unpleasant to read).

Anyway, that will be a great improvement to the dictionaries 🍾

[lasconic]

The PR is in. It doesn't cover all languages. I believe it's complete for french (except if there are subsublist...) and it improves en and pt.

[BoboTiG]

Awesome! I triggered the update workflow manually: dictionaries are coming!

[BoboTiG]

It works like a charm :)
I tried with "bruine" which has a weird etyomology and "baroud". It is pleasant to have the whole etymology 💪

[lasconic]

Great ! Thanks !