-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] Add support for the 'ar-cf' template #643
Comments
this is a hard one... We need to replicate https://fr.wiktionary.org/wiki/Module:arabe#L-474 arabe.appliquer like we did for arabiser. |
Yes. We can just postpone its handling until more words will be using it. |
Another one: https://fr.wiktionary.org/wiki/alm%C3%A9e |
ar-terme: https://fr.wiktionary.org/wiki/qasida |
ar-terme: https://fr.wiktionary.org/wiki/Muad-Dib |
Here are all words using that template:
|
So, I converted Work is still ongoing ⏲️ |
#1414 needs way more work than I expected. As stated in the documentation:
For now, the PR only tackles the last point (3). For (1) and (2), we also need to support https://fr.wiktionary.org/wiki/Mod%C3%A8le:ar-abiser I guess? It seems we cannot rely on the current It will be for later, I'll pause the work for a moment. @lasconic if you want to move on, you can use the PR as a team effort. In any cases, I'll find some time to make progress the next week, hopefully. |
I took a deep look into the issue and #1414 1/ Lua a string are 1-indexed ... while python script are 0-indexed. I have 3 working correctly now. It's not given by appliquer. Quite a bit of work and testing. I already spent some time on it. I will look further this week. |
With this PR, all the words from #643 (comment) are OK with check-word except for "schème" which uses other non supported templates (ar-racine/nom and ar-sch) |
The two big learning points about porting lua to python
|
schème is now OK with #1742 and the support of |
The text was updated successfully, but these errors were encountered: