Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Complete support for arabe templates #1414

Closed
wants to merge 5 commits into from
Closed

[FR] Complete support for arabe templates #1414

wants to merge 5 commits into from

Conversation

BoboTiG
Copy link
Owner

@BoboTiG BoboTiG commented Oct 29, 2022

Fixes #643.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 29, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 7.12%.

Quality metrics Before After Change
Complexity 105.24 ⛔ 205.68 ⛔ 100.44 👎
Method Length 306.27 ⛔ 500.14 ⛔ 193.87 👎
Working memory 24.98 ⛔ 34.29 ⛔ 9.31 👎
Quality 18.71% 11.59% -7.12% 👎
Other metrics Before After Change
Lines 1699 2444 745
Changed files Quality Before Quality After Quality Change
scripts/__main__.py 83.33% ⭐ 83.32% ⭐ -0.01% 👎
wikidict/lang/fr/__init__.py 18.71% ⛔ 18.15% ⛔ -0.56% 👎
wikidict/lang/fr/arabiser.py 0.92% ⛔ 4.30% ⛔ 3.38% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
wikidict/lang/fr/arabiser.py appliquer 325 ⛔ 3419 ⛔ 47 ⛔ 0.06% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
wikidict/lang/fr/arabiser.py arabiser 184 ⛔ 1058 ⛔ 38 ⛔ 0.25% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
wikidict/lang/fr/__init__.py last_template_handler 73 ⛔ 642 ⛔ 19 ⛔ 5.73% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
wikidict/lang/fr/arabiser.py nature 20 😞 156 😞 8 🙂 48.66% 😞 Refactor to reduce nesting. Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@lasconic
Copy link
Collaborator

See #1738

@lasconic lasconic closed this Jan 31, 2023
@BoboTiG BoboTiG deleted the fix-643 branch January 31, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Add support for the 'ar-cf' template
2 participants