Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Fix "diminutif" not taking into account "de" argument #1475

Merged
merged 1 commit into from
Jan 1, 2023
Merged

Conversation

BoboTiG
Copy link
Owner

@BoboTiG BoboTiG commented Jan 1, 2023

Fixes #1464

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 1, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.31%.

Quality metrics Before After Change
Complexity 44.66 ⛔ 50.05 ⛔ 5.39 👎
Method Length 419.17 ⛔ 423.50 ⛔ 4.33 👎
Working memory 15.47 ⛔ 15.68 ⛔ 0.21 👎
Quality 23.29% 21.98% -1.31% 👎
Other metrics Before After Change
Lines 1553 1564 11
Changed files Quality Before Quality After Quality Change
tests/test_fr.py 53.04% 🙂 53.08% 🙂 0.04% 👍
wikidict/lang/fr/__init__.py 19.95% ⛔ 18.71% ⛔ -1.24% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
wikidict/lang/fr/__init__.py last_template_handler 70 ⛔ 608 ⛔ 19 ⛔ 5.94% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
tests/test_fr.py test_parse_word 0 ⭐ 483 ⛔ 10 😞 50.32% 🙂 Try splitting into smaller methods. Extract out complex expressions
tests/test_fr.py test_process_templates 0 ⭐ 324 ⛔ 5 ⭐ 64.14% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@BoboTiG BoboTiG merged commit 7126517 into master Jan 1, 2023
@BoboTiG BoboTiG deleted the fix-1464 branch January 1, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Fix "diminutif" not taking into account "de" argument
1 participant