Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Fix "diminutif" not taking into account "de" argument #1464

Closed
BoboTiG opened this issue Dec 30, 2022 · 0 comments · Fixed by #1475
Closed

[FR] Fix "diminutif" not taking into account "de" argument #1464

BoboTiG opened this issue Dec 30, 2022 · 0 comments · Fixed by #1475
Assignees
@BoboTiG
Labels
locale:French

Comments

@BoboTiG
Copy link
Owner

BoboTiG commented Dec 30, 2022 •
edited

Wikicode:

{{diminutif|fr|m=1|de=source}}

Output:

Diminutif

Expected:

Diminutif de <i>source</i>

We can see we are badly handling it:

ebook-reader-dict/tests/test_fr.py

Line 466 in ebfbf3e

("{{diminutif|fr|de=balle}}", "diminutif"),

Model link, if any: https://fr.wiktionary.org/w/index.php?title=Mod%C3%A8le:diminutif
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BoboTiG BoboTiG

Labels
locale:French
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FR] Fix "diminutif" not taking into account "de" argument BoboTiG/ebook-reader-dict
1 participant
@BoboTiG