try to fix #1494

[lasconic]

Fixes #1494

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 3.28%.

Quality metrics	Before	After	Change
Complexity	3.09 ⭐	2.92 ⭐	-0.17 👍
Method Length	85.52 🙂	77.76 🙂	-7.76 👍
Working memory	7.60 🙂	7.38 🙂	-0.22 👍
Quality	69.55% 🙂	72.83% 🙂	3.28% 👍

Other metrics	Before	After	Change
Lines	837	822	-15

Changed files	Quality Before	Quality After	Quality Change
scripts/__main__.py	83.33% ⭐	83.32% ⭐	-0.01% 👎
wikidict/utils.py	65.44% 🙂	69.19% 🙂	3.75% 👍
wikidict/lang/__init__.py	81.86% ⭐	82.92% ⭐	1.06% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
wikidict/utils.py	transform	8 ⭐	132 😞	10 😞	57.08% 🙂	Try splitting into smaller methods. Extract out complex expressions
wikidict/utils.py	process_templates	9 🙂	157 😞	8 🙂	57.68% 🙂	Try splitting into smaller methods
wikidict/utils.py	clean	3 ⭐	127 😞	11 😞	60.64% 🙂	Try splitting into smaller methods. Extract out complex expressions
wikidict/utils.py	table2html	6 ⭐	80 🙂	11 😞	64.02% 🙂	Extract out complex expressions
wikidict/utils.py	get_word_of_the_day	1 ⭐	142 😞	9 🙂	64.85% 🙂	Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[BoboTiG]

good for review, it's done on my side.

[BoboTiG]

This is a ugly hack for "Annexe" and "Fichier". We want to keep namespaces using at least one template, like [[Annexe:blablabla|{{foo:|bar}}]] but bot simple calls like [[Fichier:blablabla|foo|bar]].

It's fragile. If you can find another way, I'm open :)

[BoboTiG]

Maybe I found another way.

If we decided to parse those wikicode, and filter out later.
We really need to keep namespaces that doesn't end with a filename: we could do that check. If it seems to end with a file extension, then filter out. Else, keep the wikicode.

[BoboTiG]

We need to add more examples to be sure about a strategy.

[BoboTiG]

Well, WDYT about merging that PR as-is? Let's see what breaks then, I'm not motivated to complexify more the code for that use case (not now at least).

[lasconic]

Sure, let's merge and see.