Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CA] Support multiple arguments in "q" template #1534

Merged
merged 1 commit into from
Jan 17, 2023
Merged

[CA] Support multiple arguments in "q" template #1534

merged 1 commit into from
Jan 17, 2023

Conversation

BoboTiG
Copy link
Owner

@BoboTiG BoboTiG commented Jan 17, 2023

Fixes #1527

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 17, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.01%.

Quality metrics Before After Change
Complexity 50.07 ⛔ 50.07 ⛔ 0.00
Method Length 176.67 😞 177.17 😞 0.50 👎
Working memory 1.46 ⭐ 1.46 ⭐ 0.00
Quality 20.80% 20.79% -0.01% 👎
Other metrics Before After Change
Lines 574 578 4
Changed files Quality Before Quality After Quality Change
tests/test_ca.py 61.77% 🙂 61.67% 🙂 -0.10% 👎
wikidict/lang/ca/__init__.py 16.31% ⛔ 16.31% ⛔ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
wikidict/lang/ca/__init__.py last_template_handler 67 ⛔ 522 ⛔ 2.36% ⛔ Refactor to reduce nesting. Try splitting into smaller methods
tests/test_ca.py test_parse_word 0 ⭐ 294 ⛔ 9 🙂 55.47% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@BoboTiG BoboTiG merged commit 0eaae55 into master Jan 17, 2023
@BoboTiG BoboTiG deleted the fix-1527 branch January 17, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CA] Support multiple arguments in "q" template
1 participant